Scala + Caliban で作るGraphQL バックエンド / Making GraphQL Backend with Scala + Caliban
How to do a code review The pages in this section contain recommendations on the best way to do code reviews, based on long experience. All together they represent one complete document, broken up into many separate sections. You don’t have to read them all, but many people have found it very helpful to themselves and their team to read the entire set. The Standard of Code Review What to Look For
How to write code review comments Summary Be kind. Explain your reasoning. Balance giving explicit directions with just pointing out problems and letting the developer decide. Encourage developers to simplify code or add code comments instead of just explaining the complexity to you. Courtesy In general, it is important to be courteous and respectful while also being very clear and helpful to the
The Standard of Code Review The primary purpose of code review is to make sure that the overall code health of Google’s code base is improving over time. All of the tools and processes of code review are designed to this end. In order to accomplish this, a series of trade-offs have to be balanced. First, developers must be able to make progress on their tasks. If you never submit an improvement to
What The Diff automatically writes pull request descriptions, sends out summarized notifications to keep non-technical stakeholders in the loop, and helps you to refactor minor issues during the review. FeaturesPull requests are the heartbeat of your development process. What The Diff helps you to make them accessible for everyone. Automated PR descriptionsLet the AI do the time consuming and bori
When it comes to code reviews, it’s a common phenomenon that there is much focus and long-winded discussions around mundane aspects like code formatting and style, whereas important aspects (does the code change do what it is supposed to do, is it performant, is it backwards-compatible for existing clients, and many others) tend to get less attention. To raise awareness for the issue and providing
From reviewdog v0.9.13, it now supports GitHub Actions integration. You can use github-pr-check reporter to report results to GitHub Check with GITHUB_TOKEN which is automatically generated in GitHub Actions. No need to create a bot account and personal access token anymore and no need to install reviewdog GitHub App too! - name: Setup reviewdog run: | mkdir -p $HOME/bin && curl -sfL https://raw.g
Detect, track, and fix code security vulnerabilities anywhere in the development cycle using ML and automated reasoning Amazon CodeGuru Security is a static application security testing (SAST) tool that combines machine learning (ML) and automated reasoning to identify vulnerabilities in your code, provide recommendations on how to fix the identified vulnerabilities, and track the status of the vu
チームでの Renovate 運用を Code review assignment で自動アサインすることで持続させる! Renovateをチームで運用できてますか? 問題なく運用できているかと言われたら「Yes!」と答えるのは難しい点もあるかと思います。 では、Renovateの対応は何が難しいのでしょうか? Dependencyが多いためPRも多くなり、処理しきれない 機能開発が優先になっていて手が回らない 関心がある人しか対応していない CIが通っていなく、修正のコストを考えるとアップデートしない方がいいという考えになる など様々な要因が考えられます。 僕個人の主観ですが、関心がない人はRenovateをそもそも導入していない?にもかかわらず、チーム内で運用できていないのは機能開発が優先になっているという側面は大きそう... Renovateを継続的にチームで運用していくために、この
People think they lack motivation, what they really lack is clarity – James Clear, Atomic Habits Code review innocently asks a staggering question: “does this code look good to you?” It’s not even clear how to start to answer this question – which makes putting off code reviews easy. With so many decisions left for the reviewer, the easiest decision is to opt out – to defer code review for a time
Move faster, wait less: Improving code review time at Meta Code reviews are one of the most important parts of the software development process At Meta we’ve recognized the need to make code reviews as fast as possible without sacrificing quality We’re sharing several tools and steps we’ve taken at Meta to reduce the time waiting for code reviews When done well, code reviews can catch bugs, teach
Firebase Security Rules gate your user’s access to and enforce validations for Firestore, Firebase Storage, and the Realtime Database. It’s important to code review the Security Rules, just like you code review the application code. Because these rules are written in a domain-specific language, that puts some people in the position of code reviewing something they don’t feel like they understand.
What to look for in a code review Note: Always make sure to take into account The Standard of Code Review when considering each of these points. Design The most important thing to cover in a review is the overall design of the CL. Do the interactions of various pieces of code in the CL make sense? Does this change belong in your codebase, or in a library? Does it integrate well with the rest of yo
TL;DRCode review should probably always be your top priority, and you should figure out the best way to work it into your event loop.Make your code review requests a pleasure to read.I wrote this in March 2014 when I was managing the User Lookup Service team at Twitter, to codify our theory of and approach to code review, and to try to establish some basic best practices. It’s not intended to tell
Many authors write tons of paragraphs and explain the main content in between them, let me not create nuisance here and get directly to the point so that without wasting a second, you geeks out here can utilise this checklist and become a master in code review. Keep the components small, If the size exceeds 200-300 lines then create child components. JSX markup should be no more than 50 lines. Eve
Tech companies are often criticized for a lack of diversity in their engineering workforce. In recent years, such companies have improved engineering workforce diversity through hiring and retention efforts, according to publicly available diversity reports.a However, we know little about the day-to-day, on-the-job experiences of traditionally underrepresented engineers once they join an organizat
Print Your Code for review by Elon Musk.Most code is reviewed in Github, Gitlab or somewhere online, but that is too efficient. Why not print out your code and submit the printout by fax for review by Elon Musk personally!
Previously published as a PDF Code Review Handbook: Code Review Basics How do you do a code review? Typically, I get an email from bitbucket or Github saying “Adam added you as a reviewer on ‘SMB-1182-larger-buttons’”. This is probably the 10th PR of the day, it is a constant stream. Often there is a 20 file PR that I just do not want to get started on. This is the industry standard PR environmen
The CL author’s guide to getting through code review The pages in this section contain best practices for developers going through code review. These guidelines should help you get through reviews faster and with higher-quality results. You don’t have to read them all, but they are intended to apply to every Google developer, and many people have found it helpful to read the whole set. Writing Goo
Vladimir Dementyev for Evil Martians Posted on Jul 2, 2019 • Updated on Jul 7, 2019 • Originally published at evilmartians.com This article is a b-side of my recent RailsConf talk "Terraforming legacy Rails applications" (video, slides). We, developers, spend an essential part of our work time doing code reviews. Sometimes much more time than writing code. And even spending hours couldn't save you
はじめに Google’s Engineering Practices documentation にて公開されている レビュー方法 を読んでみました。 こちら:How to do a code review これを読んでどんなことが書いてあるのかをサッとまとめるとともに、自分の考えも交えながら整理してみます。 ※基本的に ※印 の箇所が自分の考えとかだったりします。 また、本書ではCLという単語が頻繁に出現しますが、Create a change list のことです。 参考:CL 標準的なコードレビュー コードレビューの目的は、コードレビューを通してコードの健全性が向上することです。 コードの健全性については、こちらを参照して下さい。 参考:Code Health ただし、コードレビューの実践にはいくつかのトレードオフが存在します。 開発者がコミットしない限りはコードは良くならないが、
This page collects common comments made during reviews of Go code, so that a single detailed explanation can be referred to by shorthands. This is a laundry list of common style issues, not a comprehensive style guide. You can view this as a supplement to Effective Go. Additional comments related to testing can be found at Go Test Comments Google has published a longer Go Style Guide. Please discu
We are continuously working on supporting more platforms and languages. Tell us what platform do you use: support@getcodeflow.com Connect your Git repositorySetup CodeFlow to track every code change in your source control. It will take you only a few seconds. Save time on code reviewsAutomatically identify new static analysis issues, code duplications and cyclomatic complexity evolution in every c
by Sue Denim [Please note: a follow-up analysis is now available here.] Imperial finally released a derivative of Ferguson’s code. I figured I’d do a review of it and send you some of the things I noticed. I don’t know your background so apologies if some of this is pitched at the wrong level. My background. I have been writing software for 30 years. I worked at Google between 2006 and 2014, where
この記事は マイナビ Advent Calendar 2019 8日目の記事となります. 前日は「チャットボットをもくもくして運用した1年間の軌跡」でした.このチャットボット,普段は結構クレイジーな発言が多いですが投げかけた言葉に対して的確に答えたり,盛り上げてくれるようなことをたまに言うので社内で結構人気です.一番スゲーと思ったシーンはこちら(内容は意味わからない感じですが笑笑). なので↑の記事も是非見てみてください🤖. 前置きはこの辺にして,今回は先日開催された「GitHubUniverse」で発表された「Code review assignment」という機能の使い方についてまとめようと思います. この機能を設定すると,プルリクエストのコードレビューでチームメンバーからレビュアーを自動でアサインすることができるようになります. github.blog PRのコードレビューのアサイ
j次のブックマーク
k前のブックマーク
lあとで読む
eコメント一覧を開く
oページを開く